From: Allison Henderson <allison.henderson@oracle.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>, guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 3/2] xfs/010: use correct type for finobt corrupting
Date: Tue, 26 Feb 2019 13:17:35 -0700 [thread overview]
Message-ID: <0ea07e96-bdf0-9b6a-ef70-55c624a97b2e@oracle.com> (raw)
In-Reply-To: <20190226034628.GB7159@magnolia>
On 2/25/19 8:46 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Use 'type finobt' for corrupting the finobt.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/xfs/010 | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/xfs/010 b/tests/xfs/010
> index ee1595c8..e220a651 100755
> --- a/tests/xfs/010
> +++ b/tests/xfs/010
> @@ -63,14 +63,14 @@ _corrupt_finobt_records()
> _filter_dbval`
>
> # Corrupt a freecount value. This should never exceed 64.
> - $XFS_DB_PROG -x -c "fsb $free_root" -c "type inobt" \
> + $XFS_DB_PROG -x -c "fsb $free_root" -c "type finobt" \
> -c "write recs[1].freecount 70" $dev
>
> # Create a corrupted non-free record, which should never appear in the
> # finobt.
> - $XFS_DB_PROG -x -c "fsb $free_root" -c "type inobt" \
> + $XFS_DB_PROG -x -c "fsb $free_root" -c "type finobt" \
> -c "write recs[2].freecount 0" $dev
> - $XFS_DB_PROG -x -c "fsb $free_root" -c "type inobt" \
> + $XFS_DB_PROG -x -c "fsb $free_root" -c "type finobt" \
> -c "write recs[2].free 0" $dev
> }
>
>
Good catch, this looks like a pretty old test too. Thanks for the fix!
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
next prev parent reply other threads:[~2019-02-26 20:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 2:35 [PATCH 1/2] misc: don't oom the box opening tmpfiles Darrick J. Wong
2019-02-26 2:35 ` [PATCH 2/2] t_attr_corruption: fix this yet again Darrick J. Wong
2019-02-26 20:03 ` Allison Henderson
2019-02-28 20:56 ` Jeff Mahoney
2019-03-02 9:32 ` Eryu Guan
2019-02-26 3:46 ` [PATCH 3/2] xfs/010: use correct type for finobt corrupting Darrick J. Wong
2019-02-26 20:17 ` Allison Henderson [this message]
2019-02-26 19:08 ` [PATCH 1/2] misc: don't oom the box opening tmpfiles Allison Henderson
2019-02-26 21:05 ` Darrick J. Wong
2019-02-26 22:24 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ea07e96-bdf0-9b6a-ef70-55c624a97b2e@oracle.com \
--to=allison.henderson@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox