From: Jan Tulak <jtulak@redhat.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, lczerner@redhat.com, dsterba@suse.cz
Subject: Re: [PATCH v6] fstests: Tests can use any name now, not 3 digits only.
Date: Fri, 27 Mar 2015 05:15:33 -0400 (EDT) [thread overview]
Message-ID: <1261993987.3620806.1427447733123.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20150327072539.GB4810@dhcp-13-216.nay.redhat.com>
----- Original Message -----
> From: "Eryu Guan" <eguan@redhat.com>
> To: "Jan Ťulák" <jtulak@redhat.com>
> Cc: fstests@vger.kernel.org, lczerner@redhat.com, dsterba@suse.cz
> Sent: Friday, 27 March, 2015 8:25:39 AM
> Subject: Re: [PATCH v6] fstests: Tests can use any name now, not 3 digits only.
>
> [...]
>
> (( 10#$foundId > 10#$id )) part is tricky, I have to lookup the bash
> manpage to understand it :)
>
> 10 is the default base, the "10#" part can be omitted.
>
> But I think simple [ $foundId -gt $id ] is better, and David Sterba is
> OK with it too now (in another reply) :-)
>
>
> Thank you so much for continuous improvements!
>
> Eryu
The 10 base was necessary here, because as I found, (( )) takes numbers beginning with zeroes as octal. So it complained about tests like 008, 009, 019, 029... The [ ] does not complain, so I will put it back here. :-)
And thanks for patience. :-)
Jan
next prev parent reply other threads:[~2015-03-27 9:15 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 15:55 [PATCH] Tests can use any name now, not 3 digits only Jan Ťulák
2015-03-18 18:01 ` Jan Tulak
2015-03-20 11:13 ` Eryu Guan
2015-03-20 15:03 ` [PATCH] fstests: tests " Jan Ťulák
2015-03-21 4:49 ` Eryu Guan
2015-03-21 12:02 ` Jan Tulak
2015-03-21 13:11 ` Eryu Guan
2015-03-25 13:27 ` [PATCH] fstests: Tests " Jan Ťulák
2015-03-25 13:32 ` Jan Tulak
2015-03-25 14:44 ` David Sterba
2015-03-25 15:20 ` Lukáš Czerner
2015-03-25 15:27 ` Jan Tulak
2015-03-25 15:43 ` Lukáš Czerner
2015-03-26 13:32 ` Jan Tulak
2015-03-25 17:09 ` Eryu Guan
2015-03-25 17:39 ` Jan Tulak
2015-03-26 13:35 ` Jan Ťulák
2015-03-26 14:41 ` David Sterba
2015-03-26 15:16 ` Jan Tulak
2015-03-26 15:44 ` David Sterba
2015-03-26 15:33 ` [PATCH v6] " Jan Ťulák
2015-03-27 7:25 ` Eryu Guan
2015-03-27 9:15 ` Jan Tulak [this message]
2015-03-27 9:19 ` Eryu Guan
2015-03-27 9:15 ` [PATCH v7] " Jan Ťulák
2015-03-27 9:39 ` Eryu Guan
2015-03-27 9:48 ` Jan Tulak
2015-03-27 11:15 ` Eryu Guan
2015-03-27 11:30 ` Jan Tulak
2015-03-27 11:29 ` [PATCH v8] " Jan Ťulák
2015-03-27 11:49 ` [PATCH v9] " Jan Ťulák
2015-03-27 14:33 ` Eryu Guan
2015-03-30 13:44 ` David Sterba
2015-04-01 4:35 ` Dave Chinner
2015-04-01 12:09 ` Jan Tulak
2015-04-01 12:15 ` Lukáš Czerner
2015-04-01 13:17 ` [PATCH v10] " Jan Ťulák
2015-03-20 15:04 ` [PATCH] " Jan Tulak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261993987.3620806.1427447733123.JavaMail.zimbra@redhat.com \
--to=jtulak@redhat.com \
--cc=dsterba@suse.cz \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=lczerner@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox