Re: [PATCH 1/2 v2] Add checks for hard links support.

Dave Chinner
2015-08-31T00:21:46Z

On Mon, Aug 31, 2015 at 09:43:33AM +1000, Dave Chinner wrote:
> On Fri, Aug 28, 2015 at 01:25:00PM +0300, Ari Sundholm wrote:
> > From: Ari Sundholm <ari@tuxera.com>
> >
> > There are filesystems that do not support hard links that we want to run
> > xfstests on. Add a function for checking for support and use it wherever
> > hard links are used.
>
> As I've already pointed out, all of the filesystems that xfstests
> supports have working hardlinks, so this is a test that will never
> fail for anyone running xfstests on supported filesystems.
>
> Also, I'm left to wonder what kernel filesystem supports
> journaling but does not support hardlinks (as noted by the number of
> tests you change that have "_require_metadata_journaling"). Why
> aren't you also posting the patches to support the filesystem that
> requires this "don't use hardlinks" patch?

Just to clarify this: I don't care if people are using xfstests to
test proprietary filesystem modules. I'm happy to add proper support
for just about any filesystem, but that support needs to be *in
full* so *anyone* can run the tests on that filesystem.

What I really don't like is people being evasive about the reason
they want something changed. If there isn't a clear, full and
convincing explanation of why a change should be made, then I will
push back until such an explanation is given.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com