public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Justin Maggard <jmaggard10@gmail.com>
To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Cc: Justin Maggard <jmaggard@netgear.com>
Subject: [PATCH] btrfs: test quota disable during quota rescan
Date: Fri,  6 Nov 2015 10:40:21 -0800	[thread overview]
Message-ID: <1446835221-11905-1-git-send-email-jmaggard@netgear.com> (raw)

This test case tests if we are able to disable quotas on a filesystem
while a quota rescan is running.  Up to now (4.3) this would result
in a kernel NULL pointer dereference.

Fixed by patch (btrfs: qgroup: fix quota disable during rescan).

Signed-off-by: Justin Maggard <jmaggard@netgear.com>
---
 tests/btrfs/115     | 62 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/115.out |  2 ++
 tests/btrfs/group   |  1 +
 3 files changed, 65 insertions(+)
 create mode 100755 tests/btrfs/115
 create mode 100644 tests/btrfs/115.out

diff --git a/tests/btrfs/115 b/tests/btrfs/115
new file mode 100755
index 0000000..0d1cb3a
--- /dev/null
+++ b/tests/btrfs/115
@@ -0,0 +1,62 @@
+#! /bin/bash
+# FS QA Test No. btrfs/115
+#
+# btrfs quota scan/disable sanity test
+# Make sure that disabling quotas during a quota rescan doesn't crash
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2015 NETGEAR, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+	cd /
+	rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs btrfs
+_supported_os Linux
+_require_scratch
+
+_scratch_mkfs >>$seqres.full 2>&1
+_scratch_mount
+
+for i in `seq 0 1 450000`; do
+	echo -n > $SCRATCH_MNT/file.$i
+done
+echo 3 > /proc/sys/vm/drop_caches
+$BTRFS_UTIL_PROG quota enable $SCRATCH_MNT
+$BTRFS_UTIL_PROG quota disable $SCRATCH_MNT
+
+
+echo "Silence is golden"
+status=0
+exit
diff --git a/tests/btrfs/115.out b/tests/btrfs/115.out
new file mode 100644
index 0000000..d9dd136
--- /dev/null
+++ b/tests/btrfs/115.out
@@ -0,0 +1,2 @@
+QA output created by 115
+Silence is golden
diff --git a/tests/btrfs/group b/tests/btrfs/group
index 10ab26b..39b9aff 100644
--- a/tests/btrfs/group
+++ b/tests/btrfs/group
@@ -117,3 +117,4 @@
 112 auto quick clone
 113 auto quick compress clone
 114 auto qgroup
+115 auto qgroup
-- 
2.6.3


             reply	other threads:[~2015-11-06 18:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06 18:40 Justin Maggard [this message]
2015-11-07 15:08 ` [PATCH] btrfs: test quota disable during quota rescan Filipe Manana
2015-11-08 21:51   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446835221-11905-1-git-send-email-jmaggard@netgear.com \
    --to=jmaggard10@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=jmaggard@netgear.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox