From: Jia He <hejianet@gmail.com>
To: fstests@vger.kernel.org
Cc: eguan@redhat.com, Jia He <hejianet@gmail.com>
Subject: [PATCH V2 1/2] fstests: add user friendly prompts for already mounted points name
Date: Sat, 9 Jan 2016 11:54:52 +0800 [thread overview]
Message-ID: <1452311693-27529-2-git-send-email-hejianet@gmail.com> (raw)
In-Reply-To: <1452311693-27529-1-git-send-email-hejianet@gmail.com>
This adds user friendly prompts to output the already mounted point from _mount.
xfstests will do the cleanup (ie. umount) and user can not get the mount name
information.
Signed-off-by: Jia He <hejianet@gmail.com>
---
common/rc | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/common/rc b/common/rc
index d33e3fb..f0caef2 100644
--- a/common/rc
+++ b/common/rc
@@ -1271,7 +1271,9 @@ _require_scratch_nocheck()
# if it's mounted, make sure its on $SCRATCH_MNT
if ! _mount | grep -F $SCRATCH_DEV | grep -q $SCRATCH_MNT
then
- echo "\$SCRATCH_DEV is mounted but not on \$SCRATCH_MNT - aborting"
+ echo "\$SCRATCH_DEV=$SCRATCH_DEV is mounted but not on \$SCRATCH_MNT=$SCRATCH_MNT - aborting"
+ echo "Already mounted result:"
+ _mount | grep -F $SCRATCH_DEV
exit 1
fi
# and then unmount it
@@ -1353,7 +1355,9 @@ _require_test()
# if it's mounted, make sure its on $TEST_DIR
if ! _mount | grep -F $TEST_DEV | grep -q $TEST_DIR
then
- echo "\$TEST_DEV is mounted but not on \$TEST_DIR - aborting"
+ echo "\$TEST_DEV=$TEST_DEV is mounted but not on \$TEST_DIR=$TEST_DIR - aborting"
+ echo "Already mounted result:"
+ _mount | grep -F $TEST_DEV
exit 1
fi
else
--
2.1.4
next prev parent reply other threads:[~2016-01-09 3:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 3:54 [PATCH V2 0/2] fstests: help user to troubleshoot the re-mount issue quickly Jia He
2016-01-09 3:54 ` Jia He [this message]
2016-01-09 3:54 ` [PATCH V2 2/2] fstests: canonicalize the mount points by removing the trailing "/" Jia He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452311693-27529-2-git-send-email-hejianet@gmail.com \
--to=hejianet@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox