From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com ([209.132.183.28]:50862 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728181AbeLTDDP (ORCPT ); Wed, 19 Dec 2018 22:03:15 -0500 Date: Wed, 19 Dec 2018 22:03:14 -0500 (EST) From: Xiaoli Feng Message-ID: <1452958469.61405906.1545274994447.JavaMail.zimbra@redhat.com> In-Reply-To: References: <1545191068-6719-1-git-send-email-xifeng@redhat.com> <20181219071834.GA14993@infradead.org> <966737066.61401666.1545272222334.JavaMail.zimbra@redhat.com> Subject: Re: [PATCH v1] xfstests: filter the default EA MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: fstests-owner@vger.kernel.org To: Steve French Cc: Christoph Hellwig , fstests@vger.kernel.org, Ronnie Sahlberg , CIFS List-ID: Hi Steve, ----- Original Message ----- > From: "Steve French" > To: "Xiaoli Feng" > Cc: "Christoph Hellwig" , fstests@vger.kernel.org, "Ronnie Sahlberg" , > "sprabhu" , "CIFS" > Sent: Thursday, December 20, 2018 10:24:26 AM > Subject: Re: [PATCH v1] xfstests: filter the default EA > > On Wed, Dec 19, 2018 at 8:17 PM Xiaoli Feng wrote: > > > > Hi Christoph, > > > > ----- Original Message ----- > > > From: "Christoph Hellwig" > > > To: "XiaoLi Feng" > > > Cc: fstests@vger.kernel.org > > > Sent: Wednesday, December 19, 2018 3:18:34 PM > > > Subject: Re: [PATCH v1] xfstests: filter the default EA > > > > > > On Wed, Dec 19, 2018 at 11:44:28AM +0800, XiaoLi Feng wrote: > > > > From: xiaoli feng > > > > > > > > For some filesystems, such as CIFS, the file or directory has the > > > > default extend attribute. It makes these tests generic/020 > > > > generic/337 generic/377 failed. Now add this patch to filter the > > > > default EA. > > > > > > What is "the default EA"? This sounds like a CIFS bug to me. > > > > the default EA means the new file or directory has extended attributes. > > > > # touch cifs/file > > # getfattr cifs/file > > # file: cifs/file > > user.security.selinux > > user.security.selinux is not a cifs EA. This "default EA" is not > handled/returned by CIFS. > > cifs.ko can save/return new EAs set by the user and even return a > couple pseudo-EAs (cifs.dosattrib for example) if that EA is queried > explicitly in order to return metadata (important flags needed for > backup etc.) - but this "user.security.selinux" "default EA" is not > returned by the cifs.ko code. # getfattr ~/cifs # mount //localhost/cifs ~/cifs -o user=root,password=redhat # getfattr ~/cifs getfattr: Removing leading '/' from absolute path names # file: root/cifs user.security.selinux After mount the cifs share, the mountpoint ~/cifs already has " user.security.selinux" extended attributes. I don't know who add it. > > > -- > Thanks, > > Steve >