public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: fstests@vger.kernel.org
Cc: Eryu Guan <eguan@redhat.com>
Subject: [PATCH 2/2] ext4/271: _notrun if there are journal related mount options
Date: Mon, 18 Jan 2016 13:03:27 +0800	[thread overview]
Message-ID: <1453093407-17734-2-git-send-email-eguan@redhat.com> (raw)
In-Reply-To: <1453093407-17734-1-git-send-email-eguan@redhat.com>

ext4/271 runs in no journal mode (-onoload), so running test with
journal related mount options makes no sense, and test fails after
kernel commit 1e381f60dad9 ("ext4: do not allow journal_opts for fs w/o
journal") journal related mount options are not allowed in no journal
mode. So just _notrun if there're journal related mount options.

Signed-off-by: Eryu Guan <eguan@redhat.com>
---
 tests/ext4/271 | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/ext4/271 b/tests/ext4/271
index 217d0d8..c8e41e9 100755
--- a/tests/ext4/271
+++ b/tests/ext4/271
@@ -40,6 +40,11 @@ _supported_fs ext4
 _supported_os Linux
 _need_to_be_root
 _require_scratch
+# this test needs no journal to be loaded, skip on journal related mount options
+_require_no_mount_opts "data="
+_require_no_mount_opts "commit="
+_require_no_mount_opts "journal_checksum"
+_require_no_mount_opts "journal_async_commit"
 
 rm -f $seqres.full
 _scratch_mkfs_sized $((128 * 1024 * 1024)) >> $seqres.full 2>&1
-- 
1.8.3.1


      reply	other threads:[~2016-01-18  5:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18  5:03 [PATCH 1/2] fstests: introduce _require_no_mount_opts helper Eryu Guan
2016-01-18  5:03 ` Eryu Guan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453093407-17734-2-git-send-email-eguan@redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox