public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH 3/4] defrag: require extents support for ext4 defrag
Date: Sun, 21 Feb 2016 23:26:10 -0500	[thread overview]
Message-ID: <1456115171-13191-4-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <1456115171-13191-1-git-send-email-tytso@mit.edu>

The e4defrag program requires the use of fallocate, which in turn
means that the file system must have extents.  Enforce this
requirement so we don't get test failure noise when testing ext4's
ext3 compatibility.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 common/defrag | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/common/defrag b/common/defrag
index 942593e..6fbf830 100644
--- a/common/defrag
+++ b/common/defrag
@@ -27,7 +27,9 @@ _require_defrag()
         DEFRAG_PROG="$XFS_FSR_PROG"
 	;;
     ext4|ext4dev)
-        DEFRAG_PROG="$E4DEFRAG_PROG"
+	DEFRAG_PROG="$E4DEFRAG_PROG"
+	dumpe2fs -h $SCRATCH_DEV 2> /dev/null | grep -wq extent || \
+	     _notrun "file system does not have extents, needed for defrag"
 	;;
     btrfs)
 	DEFRAG_PROG="$BTRFS_UTIL_PROG filesystem defragment"
-- 
2.5.0


  parent reply	other threads:[~2016-02-22  4:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22  4:26 [PATCH 0/4] Remaining patches to fix up tmpfs testing Theodore Ts'o
2016-02-22  4:26 ` [PATCH 1/4] xfstests: remove dependency on /proc/partitions for generic/312 Theodore Ts'o
2016-02-22  7:37   ` Christoph Hellwig
2016-02-22  4:26 ` [PATCH 2/4] generic: add _require_odirect for generic/125 Theodore Ts'o
2016-02-22  7:37   ` Christoph Hellwig
2016-02-22  4:26 ` Theodore Ts'o [this message]
2016-02-22  7:37   ` [PATCH 3/4] defrag: require extents support for ext4 defrag Christoph Hellwig
2016-02-22  4:26 ` [PATCH 4/4] common: filter warning messages from mkfs.ext4 Theodore Ts'o
2016-02-22  7:38   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456115171-13191-4-git-send-email-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox