public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: fstests@vger.kernel.org
Subject: [PATCH] fstests: make results/check.log match everybody else
Date: Fri, 25 Mar 2016 14:35:50 -0400	[thread overview]
Message-ID: <1458930950-22356-1-git-send-email-jbacik@fb.com> (raw)

results/check.log is inconsistent with what goes to stdout and $tmp.summary.  It
passes the ran and failed tests through fmt but not the "Not Run" tests for some
reason, and nobody else passes it through fmt.  So fix this to be the same
output as what goes to stdout and $tmp.summary to make for easier post parsing.
Now we'll get

Ran: <single line with all the tests>
Not run: <single line with all the not run tests>
Failures: <single line with all the failed tests>

Signed-off-by: Josef Bacik <jbacik@fb.com>
---
 check | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/check b/check
index 2986d84..5be183f 100755
--- a/check
+++ b/check
@@ -342,17 +342,18 @@ END	{ if (NR > 0) {
 
 	echo "" >>$check.log
 	date >>$check.log
-	echo $list | fmt | sed -e 's/^/    /' -e "s;$SRC_DIR/;;g" >>$check.log
-	$interrupt && echo "Interrupted!" >>$check.log
 
 	echo "SECTION       -- $section" >>$tmp.summary
 	echo "=========================" >>$tmp.summary
         if [ ! -z "$n_try" -a $n_try != 0 ]
 	then
 	    echo "Ran:$try"
+	    echo "Ran:$try" >>$check.log
 	    echo "Ran:$try" >>$tmp.summary
 	fi
 
+	$interrupt && echo "Interrupted!" >>$check.log
+
 	if [ ! -z "$notrun" ]
 	then
 	    echo "Not run:$notrun"
@@ -364,7 +365,7 @@ END	{ if (NR > 0) {
 	then
 	    echo "Failures:$bad"
 	    echo "Failed $n_bad of $n_try tests"
-	    echo "Failures:$bad" | fmt >>$check.log
+	    echo "Failures:$bad" >>$check.log
 	    echo "Failed $n_bad of $n_try tests" >>$check.log
 	    echo "Failures:$bad" >>$tmp.summary
 	    echo "Failed $n_bad of $n_try tests" >>$tmp.summary
-- 
2.8.0.rc2


                 reply	other threads:[~2016-03-25 18:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458930950-22356-1-git-send-email-jbacik@fb.com \
    --to=jbacik@fb.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox