Re: [PATCH] fstests: generic test for fsync after adding a link and moving other inode

Eryu Guan
2016-04-07T07:36:45Z

On Wed, Apr 06, 2016 at 11:11:56PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> Test that if we create a hard link for a file F in some directory A,
> then move some directory or file B from its parent directory C into
> directory A, fsync file F, power fail and mount the filesystem, the
> directory/file B is located only at directory A and both links for
> file F exist.
>
> This test is motivated by an issue found in btrfs which is fixed by the
> following patch for the linux kernel:
>
> Btrfs: fix for incorrect directory entries after fsync log replay
>
> Tested against ext3/4, xfs, reiserfs and f2fs.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Looks good to me. Test passed with ext3/4 and xfs, failed with btrfs as
expected.

Reviewed-by: Eryu Guan <eguan@redhat.com>