Re: [PATCH 1/5] src/copy_file_range: Add a program for testing vfs_copy_file_range()

Anna Schumaker
2016-05-17T14:47:46Z

On 05/16/2016 07:20 PM, Dave Chinner wrote:
> On Fri, May 13, 2016 at 04:50:48PM -0400, Anna Schumaker wrote:
>> This will be used by the various copy tests to call the Linux
>> copy_file_range() system call. I used src/cloner.c as a reference while
>> writing this tool.
>
> Hmmm - I'd much prefer to see this added to xfs_io as it's a kernel
> syscall that lots of filesystems will eventually implement. A
> one-off binary for xfstests is fine for non-standard or deeply
> filesysetm specific stuff, but if it's generic we try to put it into
> xfs_io so that it's available to everyone writing scripts, not just
> xfstests....

Ah, that makes sense. Thanks for explaining the convention! I'll look into adding it to the xfs_io program instead. Should I send that patch to a different mailing list than fstests@vger.kernel.org?

Thanks,
Anna

>
> Cheers,
>
> Dave.
>