Re: [PATCH 1/5] src/copy_file_range: Add a program for testing vfs_copy_file_range()

Anna Schumaker
2016-05-17T17:52:11Z

On 05/17/2016 01:48 PM, Darrick J. Wong wrote:
> On Tue, May 17, 2016 at 10:47:42AM -0400, Anna Schumaker wrote:
>> On 05/16/2016 07:20 PM, Dave Chinner wrote:
>>> On Fri, May 13, 2016 at 04:50:48PM -0400, Anna Schumaker wrote:
>>>> This will be used by the various copy tests to call the Linux
>>>> copy_file_range() system call. I used src/cloner.c as a reference while
>>>> writing this tool.
>>>
>>> Hmmm - I'd much prefer to see this added to xfs_io as it's a kernel
>>> syscall that lots of filesystems will eventually implement. A
>>> one-off binary for xfstests is fine for non-standard or deeply
>>> filesysetm specific stuff, but if it's generic we try to put it into
>>> xfs_io so that it's available to everyone writing scripts, not just
>>> xfstests....
>>
>> Ah, that makes sense. Thanks for explaining the convention! I'll look into
>> adding it to the xfs_io program instead. Should I send that patch to a
>> different mailing list than fstests@vger.kernel.org?
>
> xfs@oss.sgi.com. I recommend looking at io/reflink.c as a template.
>
> FWIW I'd also appreciate c_f_r being wired up in xfs_io.

I'm working on it right now! I just finished fighting autotolls to get it to recognize a new file defining the "copy_range" command. Hopefully porting everything over won't be too difficult from here.

Thanks for the suggestion to look at reflink!

Anna

>
> --D
>
>>
>> Thanks,
>> Anna
>>
>>>
>>> Cheers,
>>>
>>> Dave.
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe fstests" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>