From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH] shared: don't try to use O_DIRECT in shared/277
Date: Thu, 9 Jun 2016 14:42:31 -0400 [thread overview]
Message-ID: <1465497751-3280-1-git-send-email-tytso@mit.edu> (raw)
A comment in shared/277 claims that ext4 supports O_DIRECT in
data=journalling mode. Actually, it doesn't, it was just silently
ignoring O_DIRECT, let's not try to test O_DIRECT for either ext3 or
ext4 in this test.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
tests/shared/272 | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tests/shared/272 b/tests/shared/272
index e5adf38..df1366a 100755
--- a/tests/shared/272
+++ b/tests/shared/272
@@ -31,10 +31,8 @@ tmp=/tmp/$$
status=1 # failure is the default!
trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
-# ext3 doesn't support direct IO in journalling mode
+# ext3 and ext4 doesn't support direct IO in journalling mode
write_opt_list="iflag=noatime conv=notrunc conv=fsync"
-# For filesystems that can handle it, add also direct IO test
-[ $FSTYP = "ext4" ] && write_opt_list="$write_opt_list oflag=direct"
# get standard environment, filters and checks
. ./common/rc
--
2.5.0
reply other threads:[~2016-06-09 18:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465497751-3280-1-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox