public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH] common: ext4's data=journal mode doesn't support O_DIRECT
Date: Thu,  9 Jun 2016 14:42:42 -0400	[thread overview]
Message-ID: <1465497762-3333-1-git-send-email-tytso@mit.edu> (raw)

Teach _require_odirect that ext4's data=journal mode doesn't support
O_DIRECT.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 common/rc | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/common/rc b/common/rc
index 069df58..791e6e5 100644
--- a/common/rc
+++ b/common/rc
@@ -1932,9 +1932,13 @@ _require_xfs_db_command()
 # check that kernel and filesystem support direct I/O
 _require_odirect()
 {
-       if [ $FSTYP = "ext4" ] &&
-	  echo "$MOUNT_OPTIONS" | grep -q "test_dummy_encryption" ; then
-		_notrun "ext4 encryption doesn't support O_DIRECT"
+       if [ $FSTYP = "ext4" ] ; then
+           if echo "$MOUNT_OPTIONS" | grep -q "test_dummy_encryption" ; then
+	       _notrun "ext4 encryption doesn't support O_DIRECT"
+	   fi
+           if echo "$MOUNT_OPTIONS" | grep -q "data=journal" ; then
+	       _notrun "ext4 data=journal mode doesn't support O_DIRECT"
+	   fi
        fi
        testfile=$TEST_DIR/$$.direct
        $XFS_IO_PROG -F -f -d -c "pwrite 0 20k" $testfile > /dev/null 2>&1
-- 
2.5.0


             reply	other threads:[~2016-06-09 18:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 18:42 Theodore Ts'o [this message]
2016-06-11 12:20 ` [PATCH] common: ext4's data=journal mode doesn't support O_DIRECT Eryu Guan
2016-06-11 15:45   ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465497762-3333-1-git-send-email-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox