public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: fstests@vger.kernel.org
Cc: Eryu Guan <eguan@redhat.com>
Subject: [PATCH] common/rc: ignore MKFS_OPTIONS in _scratch_mkfs_xfs_supported()
Date: Sun, 12 Jun 2016 15:57:09 +0800	[thread overview]
Message-ID: <1465718229-19485-1-git-send-email-eguan@redhat.com> (raw)

In recent mkfs updates in xfsprogs, commit 9090e187bc3e ("mkfs: add
respecification detection to generic parsing") added re-specification
detection to "-m" option, it causes several tests _notrun if
MKFS_OPTIONS has the same options as those being tested in
_scratch_mkfs_xfs_supported(), because they're specified multiple times.

	MKFS_OPTIONS="-m crc=0" ./check xfs/001
	xfs/001 3s ... [not run] mkfs.xfs doesn't have crc feature

Fix it by removing MKFS_OPTIONS when testing mkfs features in
_scratch_mkfs_xfs_supported(), only $mkfs_opts matters.

Signed-off-by: Eryu Guan <eguan@redhat.com>
---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/rc b/common/rc
index 51092a0..c7a7667 100644
--- a/common/rc
+++ b/common/rc
@@ -477,7 +477,7 @@ _scratch_mkfs_xfs_supported()
 
 	_scratch_options mkfs
 
-	$MKFS_XFS_PROG -N $MKFS_OPTIONS $SCRATCH_OPTIONS $mkfs_opts $SCRATCH_DEV
+	$MKFS_XFS_PROG -N $SCRATCH_OPTIONS $mkfs_opts $SCRATCH_DEV
 }
 
 _scratch_mkfs_xfs()
-- 
2.5.5


             reply	other threads:[~2016-06-12  7:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-12  7:57 Eryu Guan [this message]
2016-06-17 16:50 ` [PATCH] common/rc: ignore MKFS_OPTIONS in _scratch_mkfs_xfs_supported() Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465718229-19485-1-git-send-email-eguan@redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox