public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: fstests@vger.kernel.org
Cc: Jan Kara <jack@suse.cz>
Subject: [PATCH] ext4/271: Fix test failure with data=<foo> mount option
Date: Thu, 16 Jun 2016 12:05:11 +0200	[thread overview]
Message-ID: <1466071511-30069-1-git-send-email-jack@suse.cz> (raw)

The test is failing when MOUNT_OPTIONS contain 'data=<foo>' mount option
as it does not combine with 'noload' mount option the test uses. Fix it
by removing the data=<foo> mount option. Arguably we could also fix the
problem by just skipping the test when such option is set but e.g. using
'data=writeback' is common to excercise somewhat different behavior and
it is undesirable to skip the test just because of this.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 tests/ext4/271 | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/ext4/271 b/tests/ext4/271
index d68c2719024e..417a796ffac9 100755
--- a/tests/ext4/271
+++ b/tests/ext4/271
@@ -45,6 +45,10 @@ _scratch_mkfs_sized $((128 * 1024 * 1024)) >> $seqres.full 2>&1
 
 # -onoload and EXT4_SYNC_FL on file is important becase result in
 # metadata sync writes inside ext4_handle_dirty_metadata()
+#
+# We have to be careful and remove data=<foo> mount options as they don't
+# combine with 'noload'.
+MOUNT_OPTIONS=$(echo $MOUNT_OPTIONS | sed -e 's/\([ ,]\)data=[a-zA-Z]*[,$]/\1/')
 _scratch_mount -onoload
 touch $SCRATCH_MNT/file
 $CHATTR_PROG +S $SCRATCH_MNT/file
-- 
2.6.6


             reply	other threads:[~2016-06-16 10:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 10:05 Jan Kara [this message]
2016-06-20  9:25 ` [PATCH] ext4/271: Fix test failure with data=<foo> mount option Eryu Guan
2016-06-20 10:48   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466071511-30069-1-git-send-email-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox