public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@google.com>
To: fstests@vger.kernel.org
Cc: jack@suse.cz, agruenba@redhat.com, Eric Biggers <ebiggers@google.com>
Subject: [PATCH] generic/314: don't test SGID behavior after setfacl
Date: Wed, 12 Oct 2016 15:03:08 -0700	[thread overview]
Message-ID: <1476309788-101401-2-git-send-email-ebiggers@google.com> (raw)
In-Reply-To: <1476309788-101401-1-git-send-email-ebiggers@google.com>

Linux 4.9 (since commit 073931017b49: "posix_acl: Clear SGID bit when
setting file permissions") now may clear the SGID bit when setting a
POSIX ACL, to match chmod() behavior.  This was making generic/314 fail.
Since SGID bit clearing is already tested by generic/375, just remove
the problematic portion of generic/314.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 tests/generic/314     | 8 ++------
 tests/generic/314.out | 1 -
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/tests/generic/314 b/tests/generic/314
index 65d3513..49b03e4 100755
--- a/tests/generic/314
+++ b/tests/generic/314
@@ -39,12 +39,10 @@ _cleanup()
 # get standard environment, filters and checks
 . ./common/rc
 . ./common/filter
-. ./common/attr
 
 # real QA test starts here
 _supported_fs generic
 _require_test
-_require_acls
 _require_user
 
 rm -rf $TEST_DIR/$seq-dir
@@ -56,12 +54,10 @@ chown $qa_user:12345 $TEST_DIR/$seq-dir
 # Make parent dir sgid
 chmod 2775 $TEST_DIR/$seq-dir
 
-# Make subdirs before & after acl set
+# Make subdir
 su $qa_user -c "umask 022; mkdir $TEST_DIR/$seq-dir/subdir"
-su $qa_user -c "setfacl -m u:$qa_user:rwx,d:u:$qa_user:rwx $TEST_DIR/$seq-dir"
-su $qa_user -c "mkdir $TEST_DIR/$seq-dir/subdir2"
 
-# Both subdirs should have inherited sgid
+# Subdir should have inherited sgid
 _ls_l $TEST_DIR/$seq-dir/ | grep -v total | _filter_test_dir | awk '{print $1,$NF}'
 
 status=0
diff --git a/tests/generic/314.out b/tests/generic/314.out
index b2db82b..bcd14f5 100644
--- a/tests/generic/314.out
+++ b/tests/generic/314.out
@@ -1,3 +1,2 @@
 QA output created by 314
 drwxr-sr-x subdir
-drwxrwsr-x+ subdir2
-- 
2.8.0.rc3.226.g39d4020


      reply	other threads:[~2016-10-12 22:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12 22:03 [PATCH] generic/375: test both regular file and directory Eric Biggers
2016-10-12 22:03 ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476309788-101401-2-git-send-email-ebiggers@google.com \
    --to=ebiggers@google.com \
    --cc=agruenba@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=jack@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox