public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH v4 10/10] generic/064: access SCRATCH_MNT after _scratch_mount
Date: Thu, 16 Feb 2017 21:57:08 +0200	[thread overview]
Message-ID: <1487275028-29885-11-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1487275028-29885-1-git-send-email-amir73il@gmail.com>

Test is calling _get_block_size $SCRATCH_MNT before
_scratch_mount. This results in block size of the
wrong fs and a failure with overlay base fs setup.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
 tests/generic/064 | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tests/generic/064 b/tests/generic/064
index 8cd31b3..156485e 100755
--- a/tests/generic/064
+++ b/tests/generic/064
@@ -46,14 +46,16 @@ _require_scratch
 _require_xfs_io_command "fiemap"
 _require_xfs_io_command "finsert"
 _require_xfs_io_command "fcollapse"
-src=$SCRATCH_MNT/testfile
-dest=$SCRATCH_MNT/testfile.dest
-BLOCKS=100
-BSIZE=`_get_block_size $SCRATCH_MNT`
+
 rm -f $seqres.full
 
 _scratch_mkfs >> $seqres.full 2>&1 || _fail "mkfs failed"
 _scratch_mount || _fail "mount failed"
+
+src=$SCRATCH_MNT/testfile
+dest=$SCRATCH_MNT/testfile.dest
+BLOCKS=100
+BSIZE=`_get_block_size $SCRATCH_MNT`
 length=$(($BLOCKS * $BSIZE))
 
 # Write file
-- 
2.7.4


  parent reply	other threads:[~2017-02-16 19:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16 19:56 [PATCH v4 0/10] fstests: new way to run overlay tests Amir Goldstein
2017-02-16 19:56 ` [PATCH v4 01/10] fstests: sanity check that test partitions are not mounted elsewhere Amir Goldstein
2017-02-16 19:57 ` [PATCH v4 02/10] fstests: use _test_mount() consistently Amir Goldstein
2017-02-16 19:57 ` [PATCH v4 03/10] fstests: canonicalize mount points on every config section Amir Goldstein
2017-02-16 19:57 ` [PATCH v4 04/10] overlay: rename OVERLAY_LOWER/UPPER/WORK_DIR Amir Goldstein
2017-02-16 19:57 ` [PATCH v4 05/10] overlay: allow SCRATCH_DEV to be the base fs mount point Amir Goldstein
2017-02-16 19:57 ` [PATCH v4 06/10] overlay: configure TEST/SCRATCH vars to base fs Amir Goldstein
2017-02-16 19:57 ` [PATCH v4 07/10] overlay: use OVL_BASE_SCRATCH_MNT instead of SCRATCH_DEV Amir Goldstein
2017-02-16 19:57 ` [PATCH v4 08/10] overlay: fix test and scratch filters for overlay base fs Amir Goldstein
2017-02-16 19:57 ` [PATCH v4 09/10] overlay: mount/unmount base fs before/after running tests Amir Goldstein
2017-02-16 19:57 ` Amir Goldstein [this message]
2017-02-20 10:30 ` [PATCH v4 0/10] fstests: new way to run overlay tests Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487275028-29885-11-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox