From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, Xiong Zhou <xzhou@redhat.com>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH v4 2/3] generic/079: use _require_test_program
Date: Thu, 6 Apr 2017 08:49:19 +0300 [thread overview]
Message-ID: <1491457760-9240-2-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1491457760-9240-1-git-send-email-amir73il@gmail.com>
use _require_test_program helper and specify both +i and +a
to _required_chattr, because test sets them both.
Also remove unneeded _scratch_unmount from _cleanup.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
tests/generic/079 | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/generic/079 b/tests/generic/079
index 5cceeba..c2db6bf 100755
--- a/tests/generic/079
+++ b/tests/generic/079
@@ -37,7 +37,6 @@ _cleanup()
cd /
echo "*** cleaning up"
$timmutable -r $SCRATCH_MNT/$seq
- _scratch_unmount
}
# get standard environment, filters and checks
@@ -48,11 +47,10 @@ _cleanup()
_supported_fs generic
_supported_os Linux
-_require_chattr i
+_require_chattr ia
+_require_test_program "t_immutable"
_require_scratch
-[ -x $timmutable ] || _notrun "t_immutable was not built for this platform"
-
# real QA test starts here
_scratch_mkfs >/dev/null 2>&1 || _fail "mkfs failed"
_scratch_mount || _fail "mount failed"
--
2.7.4
next prev parent reply other threads:[~2017-04-06 5:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 5:49 [PATCH v4 1/3] fstests: _require_chattr() must get an input arg Amir Goldstein
2017-04-06 5:49 ` Amir Goldstein [this message]
2017-04-06 5:49 ` [PATCH v4 3/3] overlay/030: test immutable and append-only upper files Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491457760-9240-2-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox