Re: [PATCH 2/4] src/open_by_handle: flexible usage options

Eryu Guan
2017-04-19T10:02:11Z

On Wed, Apr 19, 2017 at 12:57:49PM +0300, Amir Goldstein wrote:
...
> >> @@ -95,14 +139,32 @@ int main(int argc, char **argv)
> >> }
> >> }
> >>
> >> + /* after creating test set only check that fs supports exportfs */
> >> + if (create)
> >> + return EXIT_SUCCESS;
> >
> > "-c" means "Create N test files (nlink=1) under test_dir and exit", so
> > we could move it before name_to_handle_at() calls?
>
> That's the wording from commit message which is out of date.
> usage says -c also tries to get handles, because it is being used for
> _require_exportfs

Right, I missed that. Then yes, commit message should be updated :)

Thanks,
Eryu