From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, Xiong Zhou <xzhou@redhat.com>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 5/5] overlay/017: test persistent inode numbers after mount cycle
Date: Thu, 27 Apr 2017 18:09:35 +0300 [thread overview]
Message-ID: <1493305775-12559-6-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1493305775-12559-1-git-send-email-amir73il@gmail.com>
Overlayfs directory inodes are constant across copy up,
but not persistent on mount cycle.
Compare the inode numbers before and after mount cycle.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
tests/overlay/017 | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/tests/overlay/017 b/tests/overlay/017
index 1cf684d..fe66f4c 100755
--- a/tests/overlay/017
+++ b/tests/overlay/017
@@ -9,7 +9,8 @@
# - stat file A shows inode number Y != X
#
# Also test if d_ino of readdir entries changes after copy up
-# and if inode numbers persist after rename and drop caches.
+# and if inode numbers persist after rename, drop caches and
+# mount cycle.
#
#-----------------------------------------------------------------------
#
@@ -133,6 +134,19 @@ done
diff -u $tmp.before $tmp.after_copyup
diff -u $tmp.after_copyup $tmp.after_move
+# Verify that the inode numbers survive a mount cycle
+_scratch_cycle_mount
+
+record_inode_numbers $testdir $tmp.after_cycle
+
+cat $tmp.after_move | while read ino f; do
+ find $testdir/ -inum $ino -maxdepth 1 | grep -q $f || \
+ echo "$f not found by ino $ino"
+done
+
+# Compare before..after - expect silence
+diff -u $tmp.after_move $tmp.after_cycle
+
echo "Silence is golden"
status=0
exit
--
2.7.4
next prev parent reply other threads:[~2017-04-27 15:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 15:09 [PATCH 0/5] fstests: more tests for overlay constant inode numbers Amir Goldstein
2017-04-27 15:09 ` [PATCH 1/5] overlay/017: silence test output Amir Goldstein
2017-04-28 5:36 ` Eryu Guan
2017-04-28 5:45 ` Amir Goldstein
2017-04-28 5:50 ` Eryu Guan
2017-04-28 6:34 ` Amir Goldstein
2017-04-28 6:50 ` Eryu Guan
2017-04-27 15:09 ` [PATCH 2/5] overlay/017: use af_unix to create socket test file Amir Goldstein
2017-04-27 15:09 ` [PATCH 3/5] overlay/017: create a helper to record inode number Amir Goldstein
2017-04-27 15:09 ` [PATCH 4/5] overlay/017: verify constant inode number after rename Amir Goldstein
2017-04-28 5:47 ` Eryu Guan
2017-04-28 5:50 ` Amir Goldstein
2017-04-27 15:09 ` Amir Goldstein [this message]
2017-04-28 5:30 ` [PATCH 0/5] fstests: more tests for overlay constant inode numbers Eryu Guan
2017-04-28 5:39 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493305775-12559-6-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox