Re: [PATCH 4/4] overlay: tag tests 016-018 as experimental

Amir Goldstein
2017-05-12T06:16:06Z

On Fri, May 12, 2017 at 7:01 AM, Eryu Guan <eguan@redhat.com> wrote:
> On Thu, May 11, 2017 at 09:55:10AM +0300, Amir Goldstein wrote:
>> The tests 016-018 were added to track overlayfs 'Non-standard behavior'
>> as are documented in Documentation/filesystems/overlayfs.txt, with the
>> intention of fixing those behaviors 'some day'.
>>
>> While that day seems to be seen in the horizon, at least for test 017,
>> it may take a while longer for all those tests to pass.
>> Add those tests to group 'experimental' so at least this special status
>> is published somehow.
>>
>> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
>
> The first three patches look good to me, but I'm a bit reluctant on
> merging this one.
>
> To me, this new 'experimental' group serves as an indication of "this
> test is known to fail". But this info already can be found in commit
> logs and comments of these tests. Also fstests had been pushing back
> attempts to add "known issue" support in the past. So I'd rather drop
> this patch.
>
Perfectly fine by me.
I have no problem remembering that those tests fail and why ;)