public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Xiong Zhou <xzhou@redhat.com>
To: fstests@vger.kernel.org
Cc: Xiong Zhou <xzhou@redhat.com>
Subject: [PATCH] ltp/fsstress: check mkdir(2) return value
Date: Sat, 14 Oct 2017 15:07:17 +0800	[thread overview]
Message-ID: <1507964837-10820-1-git-send-email-xzhou@redhat.com> (raw)

If mkdir(2) fails, the following chdir(2) would fail either.
Although dirname and error message are printed, we don't know
which operation has failed.

Like this:
+/test2/fsstress.1582: No such file or directory

This trivial fix will check the return value and print detail
error info if fail.

Signed-off-by: Xiong Zhou <xzhou@redhat.com>
---
 ltp/fsstress.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/ltp/fsstress.c b/ltp/fsstress.c
index 96f48b1..1962d14 100644
--- a/ltp/fsstress.c
+++ b/ltp/fsstress.c
@@ -493,7 +493,11 @@ int main(int argc, char **argv)
             exit(1);
         }
 
-	(void)mkdir(dirname, 0777);
+	if (mkdir((const char *)dirname, 0777) < 0) {
+		fprintf(stderr, "mkdir %s failed: %s\n", dirname,
+			strerror(errno));
+		exit(1);
+	}
 	if (logname && logname[0] != '/') {
 		if (getcwd(rpath, sizeof(rpath)) < 0){
 			perror("getcwd failed");
@@ -503,7 +507,8 @@ int main(int argc, char **argv)
 		rpath[0] = '\0';
 	}
 	if (chdir(dirname) < 0) {
-		perror(dirname);
+		fprintf(stderr, "chdir %s failed: %s\n", dirname,
+			strerror(errno));
 		exit(1);
 	}
 	if (logname) {
@@ -959,7 +964,11 @@ doproc(void)
 
 	dividend = (operations + execute_freq) / (execute_freq + 1);
 	sprintf(buf, "p%x", procid);
-	(void)mkdir(buf, 0777);
+	if (mkdir((const char *)buf, 0777) < 0) {
+		fprintf(stderr, "mkdir %s failed: %s\n", buf,
+			strerror(errno));
+		exit(1);
+	}
 	if (chdir(buf) < 0 || stat64(".", &statbuf) < 0) {
 		perror(buf);
 		_exit(1);
-- 
1.8.3.1


             reply	other threads:[~2017-10-14  7:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-14  7:07 Xiong Zhou [this message]
2017-10-22 11:26 ` [PATCH] ltp/fsstress: check mkdir(2) return value Eryu Guan
2017-10-24  3:23   ` Xiong Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507964837-10820-1-git-send-email-xzhou@redhat.com \
    --to=xzhou@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox