Re: [PATCH] fstests: Add 9p network filesystem support

Eryu Guan
2017-12-21T10:22:02Z

On Thu, Dec 21, 2017 at 05:13:10AM +0200, Tuomas Tynkkynen wrote:
> On Mon, 2017-12-18 at 16:58 +0200, Tuomas Tynkkynen wrote:
> > Hi Eryu,
> >
> > On Mon, 2017-12-18 at 22:12 +0800, Eryu Guan wrote:
> > > On Tue, Dec 12, 2017 at 07:11:54PM +0200, Tuomas Tynkkynen wrote:
> > > > This commit adds support for the 9p network file system, which is
> > > > mainly
> > > > used by QEMU for sharing a file system from the host to the guest
> > > > VM.
> > > >
> > > > To run xfstests on it, launch QEMU with e.g.:
> > > >
> > > > -virtfs local,path=$TMPDIR/p9-test,security_model=mapped-
> > > > xattr,mount_tag=p9-test
> > > > -virtfs local,path=$TMPDIR/p9-scratch,security_model=mapped-
> > > > xattr,mount_tag=p9-scratch
> > > >
> > > > and inside the VM run xfstests with:
> > > >
> > > > export TEST_DEV=p9-test
> > > > export SCRATCH_DEV=p9-scratch
> > > > export MOUNT_OPTIONS="-o
> > > > trans=virtio,version=9p2000.L,cache=loose,posixacl"
> > > > export TEST_FS_MOUNT_OPTS="$MOUNT_OPTIONS"
> > >
> > > We can take 9P_MOUNT_OPTIONS as the default value for both
> > > MOUNT_OPTIONS
> > > and TEST_FS_MOUNT_OPTS in common/config, similar to
> > > CIFS_MOUNT_OPTIONS
> > > etc.
> > >
> >
> > Ok, will add in next version.
> >
>
> Oops; no. Bash doesn't like environment variables starting with

Ah, that's right.

> numbers. P9_MOUNT_OPTIONS maybe then? Though honestly, I've never used

Or PLAN9_MOUNT_OPTIONS?

> nor really understood the reason for these foo_MOUNT_OPTIONS... same
> for the -nfs etc. command line flags.

Make update fs-specific mount options in local.config file more easily
when switching filesysm type to test? You don't have to update
MOUNT_OPTIONS and TEST_FS_MOUNT_OPTS.

The '-nfs'/'-9p' command line flags are used to indicate which
filesystem it's testing and set FSTYP variable correctly. Because these
filesystems can't be detected from $TEST_DEV automatically like XFS,
ext4 etc.

Thanks,
Eryu