Re: [PATCH 0/7] Overlayfs exportfs tests

Amir Goldstein
2018-01-11T11:52:04Z

On Thu, Jan 11, 2018 at 1:43 PM, Eryu Guan <eguan@redhat.com> wrote:
> On Sun, Jan 07, 2018 at 08:07:18PM +0200, Amir Goldstein wrote:
>> Eryu,
>>
>> Following patches were used to test overlayfs NFS export.
>>
>> Patches 1-5 improve generic/exportfs tests, by adding test coverage
>> of some directory file handle use cases.
>
> open_by_handle test is covering more and more cases, thanks! OTOH, it's
> getting more and more complicated :)

Yeh, sorry about that ;-)

>
> But from a quick scan, I think it's time to stop adding new sub-tests to
> existing tests (maybe we should have done this since last time we added
> new sub-tests to generic/467), because generic/467 is getting more
> complex too and makes review harder.

Probably a good idea, but please note that patch 4/7 is fixing a test that was
not implemented correctly and test 5/7 adds a very minor variant.
An option is to split the directory related tests (those that are fixed by 4/7)
out of generic/467 and then fix them and add the new variant.

> Perhaps we can factor out some
> helper functions from generic/467 to common helpers and use them in new
> tests.
>

I don't think there is much to factor out, but we can add new tests
and clone the helpers. Let me know if you think differently after review.

Thanks,
Amir.