public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Borisov <nborisov@suse.com>
To: fstests@vger.kernel.org
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org,
	Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH] generic/015: Change the test filesystem size to 101mb
Date: Mon,  8 Jan 2018 10:43:30 +0200	[thread overview]
Message-ID: <1515401010-26802-1-git-send-email-nborisov@suse.com> (raw)

This test has been failing for btrfs for quite some time,
at least since 4.7. There are 2 implementation details of btrfs that
it exposes:

1. Currently btrfs filesystem under 100mb are created in Mixed block
group mode. Freespace accounting for it is not 100% accurate - I've
observed around 100-200kb discrepancy between a newly created filesystem,
then writing a file and deleting it and checking the free space. This
falls within %3 and not %1 as hardcoded in the test. 

2. BTRFS won't flush it's delayed allocation on file deletion if less
than 32mb are deleted. On such files we need to perform sync (missing
in the test) or wait until time elapses for transaction commit.

Since mixed mode is somewhat deprecated and btrfs is not really intended
to be used on really small devices let's just adjust the test to
create a 101mb fs, which doesn't use mixed mode and really test
freespace accounting.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 tests/generic/015 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/015 b/tests/generic/015
index 78f2b13..416c4ae 100755
--- a/tests/generic/015
+++ b/tests/generic/015
@@ -53,7 +53,7 @@ _supported_os Linux
 _require_scratch
 _require_no_large_scratch_dev
 
-_scratch_mkfs_sized `expr 50 \* 1024 \* 1024` >/dev/null 2>&1 \
+_scratch_mkfs_sized `expr 101 \* 1024 \* 1024` >/dev/null 2>&1 \
     || _fail "mkfs failed"
 _scratch_mount || _fail "mount failed"
 out=$SCRATCH_MNT/fillup.$$
-- 
2.7.4


             reply	other threads:[~2018-01-08  8:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08  8:43 Nikolay Borisov [this message]
2018-01-08 12:54 ` [PATCH] generic/015: Change the test filesystem size to 101mb Qu Wenruo
2018-01-08 13:55   ` Timofey Titovets
2018-01-09  0:29     ` Qu Wenruo
2018-01-08 14:17   ` Nikolay Borisov
2018-01-09 14:59 ` Nikolay Borisov
2018-01-10  4:05 ` Eryu Guan
2018-01-11  9:17 ` [PATCH v2] " Nikolay Borisov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1515401010-26802-1-git-send-email-nborisov@suse.com \
    --to=nborisov@suse.com \
    --cc=dsterba@suse.cz \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox