Re: [PATCH v2 0/7] Overlayfs exportfs tests

Eryu Guan
2018-01-24T10:40:25Z

On Tue, Jan 23, 2018 at 10:59:05PM +0200, Amir Goldstein wrote:
> Eryu,
>
> This is the 2nd revision of test for overlayfs NFS export.
>
> Changes since v1:
> - Added new generic/exportfs test instead of changing existing test
> - Addressed review comments on open_by_handle [-i|-o] patch
> - Added the test that uses open_by_handle [-i|-o] in the same patch
> - Split new overlay/exportfs tests to four tests, a pair of tests
> for samefs and a pair of tests for non-samefs configuration.
> - For each configuration, one test requires and enables redirect_dir
> for directory rename test cases and both tests require and enable
> nfs_export feature.
>
> The new overlay tests don't run on upstream kernel and pass with
> my overlayfs NFS export V3 branch [1]. You may want to wait with
> merging those tests until overlayfs NFS support is merged.

Yeah, I probably will wait and let the kernel patches go first. (And
I'll go through the overlay specific patches later.)

>
> Merging patches 1-3 seems like a good idea to me regardless of
> overlayfs NFS export support.

Patches 1-3 look good to me. One minor issue is that my compiler
complained about "may be used uninitialized" on 'infile' and 'outfile'

open_by_handle.c:350:12: warning: 'outfile' may be used uninitialized in this function [-Wmaybe-uninitialized]

though I don't think we'll use them uninitialized in practice, I'd like
to initialize them with NULL on commit.

Thanks for the revision!

Eryu