From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me
Subject: [PATCH 01/10] fstests: fix group check in new script
Date: Tue, 25 May 2021 18:46:48 -0700 [thread overview]
Message-ID: <162199360825.3744214.12378871174987894190.stgit@locust> (raw)
In-Reply-To: <162199360248.3744214.17042613373014687643.stgit@locust>
From: Darrick J. Wong <djwong@kernel.org>
In the tests/*/group files, group names are found in the Nth columns of
the file, where N > 1. The grep expression to warn about unknown groups
is not correct (since it currently checks column 1), so fix this.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
new | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/new b/new
index bb427f0d..357983d9 100755
--- a/new
+++ b/new
@@ -243,10 +243,7 @@ else
#
for g in $*
do
- if grep "^$g[ ]" $tdir/group >/dev/null
- then
- :
- else
+ if ! grep -q "[[:space:]]$g" "$tdir/group"; then
echo "Warning: group \"$g\" not defined in $tdir/group"
fi
done
next prev parent reply other threads:[~2021-05-26 1:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 1:46 [PATCHSET RFC 00/10] fstests: move test group lists into test files Darrick J. Wong
2021-05-26 1:46 ` Darrick J. Wong [this message]
2021-05-26 1:46 ` [PATCH 02/10] fstests: refactor setting test sequence number variables Darrick J. Wong
2021-05-26 1:46 ` [PATCH 03/10] fstests: add tool migrate group membership data to test files Darrick J. Wong
2021-05-26 1:47 ` [PATCH 04/10] fstests: move test group info " Darrick J. Wong
2021-06-03 4:58 ` Eric Biggers
2021-06-03 15:23 ` Darrick J. Wong
2021-05-26 1:47 ` [PATCH 05/10] fstests: clean up open-coded golden output Darrick J. Wong
2021-05-26 1:47 ` [PATCH 06/10] fstests: automatically generate group files Darrick J. Wong
2021-05-26 1:47 ` [PATCH 07/10] fstests: convert nextid to use automatic group generation Darrick J. Wong
2021-05-26 1:47 ` [PATCH 08/10] fstests: adapt the new test script to our new group tagging scheme Darrick J. Wong
2021-05-26 1:47 ` [PATCH 09/10] fstests: remove group files Darrick J. Wong
2021-05-26 1:47 ` [PATCH 10/10] fstests: remove test group management code Darrick J. Wong
2021-06-03 6:32 ` [PATCHSET RFC 00/10] fstests: move test group lists into test files Amir Goldstein
2021-06-03 15:34 ` Darrick J. Wong
2021-06-03 16:56 ` Amir Goldstein
2021-06-03 22:21 ` Darrick J. Wong
2021-06-06 14:44 ` Eryu Guan
2021-06-06 18:05 ` Darrick J. Wong
2021-06-07 17:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162199360825.3744214.12378871174987894190.stgit@locust \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox