Re: [PATCH] xfstests: Add first statx test

David Howells
2017-03-30T19:32:06Z

Amir Goldstein <amir73il@gmail.com> wrote:

> > (2) Optionally compares the timestamps to see that they're sensibly
> > ordered with respect to the saved clock time[**] and each other.
>
> I suggest that instead of comparing to absolute timestamp value
> compare to a timestamp of the cmp file.
> This will also solve you the problem of gettimeofday() vs. kernel_time
> and will also open up the possibility of adding more interesting tests
> later on (e.g. make sure that mtime of file A >= atime of file B).

The whole point was to compare to a preceding time to make sure the timestamp
didn't go backwards - exactly as it can do:-/. Comparing to a reference file
doesn't prove that unless you've checked the reference file...

Making use of more of a reference file's timestamps could be useful for other
checks, though.

> > +420 other
>
> Since your test takes a few seconds, you should add it to auto, quick groups
> I don't know what this 'other' group is about.

I don't know either. Ask the 'new' script.

David