From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v2] common: get fs type again using device canonical name in _fs_type
Date: Fri, 1 Aug 2014 10:21:59 +1000 [thread overview]
Message-ID: <20140801002159.GU26465@dastard> (raw)
In-Reply-To: <1406803957-10488-1-git-send-email-eguan@redhat.com>
On Thu, Jul 31, 2014 at 06:52:37PM +0800, Eryu Guan wrote:
> When testing with lvm, a previous btrfsck run could change df output
> from something like
>
> /dev/mapper/rhel_hp--dl388eg8--01-testlv1 btrfs 15728640 900 13602172 1% /mnt/btrfs
>
> to
>
> /dev/dm-3 btrfs 15728640 900 13602172 1% /mnt/btrfs
I don't follow you. Why would running btrfsck change the name of the
device? If the filesystem is umounted and mounted again, then the
device could change, but btrfsck should not be not doing the
unmount/mount, and so unless the TEST_DEV/SCRATCH_DEV is changing
the output of df should be identical...
So before we change the _fs_type() code, can you explain exactly
how, when and why the device name is changing to me?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2014-08-01 0:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-27 16:37 [PATCH] common: get fs type again using device canonical name in _fs_type Eryu Guan
2014-07-31 10:52 ` [PATCH v2] " Eryu Guan
2014-08-01 0:21 ` Dave Chinner [this message]
2014-08-01 4:02 ` Eryu Guan
2014-08-01 4:49 ` Dave Chinner
2014-08-01 5:02 ` Eryu Guan
2014-08-01 8:48 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140801002159.GU26465@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox