From: Theodore Ts'o <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>, fstests@vger.kernel.org
Subject: Re: [PATCH 2/6] common: _scratch_mkfs_sized should inherent default block size from test_dev
Date: Thu, 21 Aug 2014 10:01:06 -0400 [thread overview]
Message-ID: <20140821140106.GH11085@thunk.org> (raw)
In-Reply-To: <20140821092344.GK26465@dastard>
On that note, what is dbsize supposed to be? It appears to be set in
_filter_mkfs? It appears from context that this is supposed to be the
data block size? Currently this gets hard coded to 4k for non-xfs
file systems, and it assumes a 256 byte inode.
It looks like we should be extracting this information from dumpe2fs
for extN file systems?
- Ted
next prev parent reply other threads:[~2014-08-21 14:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 13:13 [PATCH 1/6] common: add _mkfs_dev helper Dmitry Monakhov
2014-08-16 13:13 ` [PATCH 2/6] common: _scratch_mkfs_sized should inherent default block size from test_dev Dmitry Monakhov
2014-08-20 23:14 ` Dave Chinner
2014-08-21 7:36 ` Dmitry Monakhov
2014-08-21 9:23 ` Dave Chinner
2014-08-21 14:01 ` Theodore Ts'o [this message]
2014-08-21 20:44 ` Dave Chinner
2014-08-22 13:24 ` Dmitry Monakhov
2014-08-22 15:09 ` Theodore Ts'o
2014-08-22 15:48 ` Dmitry Monakhov
2014-08-22 16:37 ` Theodore Ts'o
2014-08-23 0:31 ` Dave Chinner
2014-08-16 13:13 ` [PATCH 3/6] src/e4compact cleanup Dmitry Monakhov
2014-08-16 13:13 ` [PATCH 4/6] src/e4compact: handle various block_size correctly Dmitry Monakhov
2014-08-16 13:13 ` [PATCH 5/6] src/e4compact: add sparse file optimization Dmitry Monakhov
2014-08-16 13:13 ` [PATCH 6/6] ext4/308: add new defrag compact test case Dmitry Monakhov
2014-09-08 12:21 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821140106.GH11085@thunk.org \
--to=tytso@mit.edu \
--cc=david@fromorbit.com \
--cc=dmonakhov@openvz.org \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox