From: Dave Chinner <david@fromorbit.com>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] xfstests: add regression for inode bad compression ratio detection
Date: Wed, 8 Oct 2014 06:43:52 +1100 [thread overview]
Message-ID: <20141007194352.GF12693@dastard> (raw)
In-Reply-To: <1412724049-50613-1-git-send-email-wangshilong1991@gmail.com>
On Tue, Oct 07, 2014 at 07:20:49PM -0400, Wang Shilong wrote:
> This test add a regression test to make sure btrfs dosen't set
> inode NOCOMPRESS flag when a small write(<=blocksize) happens.
>
> Signed-off-by: Wang Shilong <wangshilong1991@gmail.com>
...
> +rm -f $seqres.full
> +
> +_scratch_mkfs >> $seqres.full 2>&1
> +_scratch_mount "-o compress=lzo"
> +
> +$XFS_IO_PROG -f -c "pwrite 0 10M" -c "fsync" \
> + $SCRATCH_MNT/data >> $seqres.full 2>&1
> +
> +filefrag $SCRATCH_MNT/data | $AWK_PROG '{print $2}'
We don't want to introduce new external dependencies if we have
internal functions that do the same thing. i.e:
. common/defrag
....
_extent_count $SCRATCH_MNT/data
Will do the same thing without introducing a dependence on filefrag.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2014-10-07 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 23:20 [PATCH] xfstests: add regression for inode bad compression ratio detection Wang Shilong
2014-10-07 19:43 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007194352.GF12693@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox