From: Dave Chinner <david@fromorbit.com>
To: Steve French <smfrench@gmail.com>
Cc: fstests@vger.kernel.org
Subject: Re: xfstest status on current kernels
Date: Thu, 13 Nov 2014 15:44:05 +1100 [thread overview]
Message-ID: <20141113044405.GF28565@dastard> (raw)
In-Reply-To: <CAH2r5mu47ev3=+z7D9tC-jwBpmys=uYe_eooiCa3CtXBNzMXXg@mail.gmail.com>
On Wed, Nov 12, 2014 at 10:33:37PM -0600, Steve French wrote:
> On Wed, Nov 12, 2014 at 10:22 PM, Dave Chinner <david@fromorbit.com> wrote:
> > On Wed, Nov 12, 2014 at 09:38:45PM -0600, Steve French wrote:
> >> On Wed, Nov 12, 2014 at 9:26 PM, Dave Chinner <david@fromorbit.com> wrote:
> >> > On Wed, Nov 12, 2014 at 05:31:20PM -0600, Steve French wrote:
> >>
> >> >> I want to make sure that I don't accidentally ignore a test (e.g. test
> >> >> generic/003 doesn't run with a message " [not run] relatime not
> >> >> supported by the current kernel" and want to make sure I am not
> >> >> missing something).
> >> I have been going through these one at a time as I have time (to
> >> see if they are workable on cifs/smb3 etc) - but it can get
> >> tricky (e.g. in this case relatime may be default behavior for fs so
> >> lack of a mount option with this exact name may be unnecessarily
> >> disabling this one on some fs)
> >
> > I don't think that's the case. Any kernel that supports relatime
> > supports the relatime mount option. It doesn't matter if the
> > filesystem defaults to it or not, MS_RELATIME is a valid mount
> > flag on all supported kernels.
>
> relatime is rejected by the kernel cifs.ko driver (I will need to fix
> that) but should be ignored.
relatime should never get to the kernel as a string fs specific
string. It's supposed to be parsed by the mount binary and passed
as the MS_RELATIME flag to the kernel, not as a string.
> Looking at the xfstest logs looks like
> noatime is going to have the same problem as well.
> I will fix these in the cifs mount parsing.
Again: MS_NOATIME.
This sounds like a bug in the mount.cifs binary, not the kernel.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2014-11-13 4:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 23:31 xfstest status on current kernels Steve French
2014-11-13 3:26 ` Dave Chinner
2014-11-13 3:38 ` Steve French
2014-11-13 4:17 ` Eric Sandeen
2014-11-13 4:22 ` Dave Chinner
2014-11-13 4:33 ` Steve French
2014-11-13 4:44 ` Dave Chinner [this message]
2014-11-13 5:09 ` Steve French
2014-11-13 5:26 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113044405.GF28565@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox