From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:57452 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753535AbaKME6S (ORCPT ); Wed, 12 Nov 2014 23:58:18 -0500 Date: Thu, 13 Nov 2014 15:58:13 +1100 From: Dave Chinner Subject: Re: [PATCH] common: enable tests that require scratch device on CIFS Message-ID: <20141113045813.GG28565@dastard> References: <1415617191-17246-1-git-send-email-eguan@redhat.com> <20141110160309.GI2863@dhcp-13-216.nay.redhat.com> <20141113032824.GB28565@dastard> <20141113042756.GE28565@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: fstests-owner@vger.kernel.org To: Steve French Cc: Eryu Guan , fstests@vger.kernel.org, "linux-cifs@vger.kernel.org" List-ID: On Wed, Nov 12, 2014 at 10:40:35PM -0600, Steve French wrote: > On Wed, Nov 12, 2014 at 10:27 PM, Dave Chinner wrote: > > On Wed, Nov 12, 2014 at 10:08:34PM -0600, Steve French wrote: > >> On Wed, Nov 12, 2014 at 9:28 PM, Dave Chinner wrote: > >> > On Wed, Nov 12, 2014 at 05:26:13PM -0600, Steve French wrote: > >> >> I get newly enabled test 294 passing on cifs mounts to Samba. > >> >> > >> >> What is best way to get the mount options passed to the mount of > >> >> scratch dev so it doesn't prompt for it? > >> > > >> > # MOUNT_OPTIONS="-o ...." ./check -g auto > >> > >> much better - that worked - thanks > >> > >> I had been using TEST_FS_MOUNT_OPTS (so I could have multiple sections > >> in local.config) rather > >> than MOUNT_OPTIONS > > > > BTW, why aren't you using CIFS_MOUNT_OPTIONS to define the login > > creds for both the test and scratch devices? That's what it was > > added for.... > > When specifying multiple sections in local.config (a common case for us > is to have one section to run tests with cifs dialect, then run again with > smb2, then again with smb3 dialect etc.). Pavel had indicated that to do this > you must use TEST_FS_MOUNT_OPTS instead of CIFS_MOUNT_OPTIONS > if you have multiple sections. I haven't found a way around this. Adding CIFS_MOUNT_OPTIONS in each section that requires a different definition should just work. If it doesn't, then please fix get_next_config() so it does and post the patch.... -Dave. -- Dave Chinner david@fromorbit.com