From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v2] generic/299: various fixes
Date: Fri, 12 Dec 2014 10:50:53 +1100 [thread overview]
Message-ID: <20141211235053.GH24183@dastard> (raw)
In-Reply-To: <1418295529-20565-1-git-send-email-eguan@redhat.com>
On Thu, Dec 11, 2014 at 06:58:49PM +0800, Eryu Guan wrote:
> Fix three problems in generic/299
>
> 1. Use $XFS_IO_PROG instead of fallocate/truncate, old distros like
> RHEL5 don't have these commands.
>
> 2. Remove $seqres.full before test, otherwise the file is growing all
> the time.
>
> 3. Make sure fio really exits, otherwise fio would block umount. $pid is
> the pid of function run_check not fio, sometimes fio is still there when
> $pid is dead and blocking umount.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
>
> v2:
> - remove $seqres.full before _require_fio, which writes to $seqres.full too
Does not apply after Eric's earlier patch "[PATCH] use xfs_io
falloc, not fallocate". Once I push out an updated tree with this
patch in it, can you rebase this patch and resend it?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2014-12-11 23:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 10:49 [PATCH] generic/299: various fixes Eryu Guan
2014-12-11 10:58 ` [PATCH v2] " Eryu Guan
2014-12-11 23:50 ` Dave Chinner [this message]
2014-12-12 2:51 ` Eryu Guan
2014-12-12 4:43 ` [PATCH v3] " Eryu Guan
2014-12-14 22:12 ` Theodore Ts'o
2014-12-14 22:17 ` Theodore Ts'o
2014-12-15 3:52 ` Eryu Guan
2014-12-15 5:02 ` [PATCH v4] " Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211235053.GH24183@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox