From: Theodore Ts'o <tytso@mit.edu>
To: Vishal Verma <vishal.l.verma@linux.intel.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v2] ext4: the _require checks for bigalloc need a larger fs size
Date: Sun, 14 Dec 2014 19:04:49 -0500 [thread overview]
Message-ID: <20141215000449.GR29787@thunk.org> (raw)
In-Reply-To: <1418335880-27252-1-git-send-email-vishal.l.verma@linux.intel.com>
On Thu, Dec 11, 2014 at 03:11:20PM -0700, Vishal Verma wrote:
> _require_ext4_bigalloc and _require_ext4_mkfs_bigalloc create a
> 200k fs. DAX (as XIP before it) relies on a fs block size ==
> system page size; ie 4k for us. With a 200k fs size limit,
> mkfs refuses to create a filesystem with a 4k block size, so
> the check fails, but for a bogus reason.
> Increasing the fs size to 512m allows mkfs to create a filesystem
> with 4k block size, so the test passes.
>
> Signed-off-by: Vishal Verma <vishal.l.verma@linux.intel.com>
> Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
LGTM
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
- Ted
prev parent reply other threads:[~2014-12-15 0:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 22:11 [PATCH v2] ext4: the _require checks for bigalloc need a larger fs size Vishal Verma
2014-12-15 0:04 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215000449.GR29787@thunk.org \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
--cc=vishal.l.verma@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox