From: Theodore Ts'o <tytso@mit.edu>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] ext4/308,generic/324: require fallocate support
Date: Mon, 15 Dec 2014 15:02:09 -0500 [thread overview]
Message-ID: <20141215200209.GK17575@thunk.org> (raw)
In-Reply-To: <20141215172937.GX15495@dhcp-13-216.nay.redhat.com>
On Tue, Dec 16, 2014 at 01:32:00AM +0800, Eryu Guan wrote:
> On Mon, Dec 15, 2014 at 10:47:23AM -0500, Theodore Ts'o wrote:
> > These tests use the falloc command in xfs_io, and there are some file
> > systems (ext3) or file system configurations (ext4 in ext3
> > compatibility mode) which do not support fallocate. So add the
> > explicit requirement to avoid false test failures.
>
> The two tests fail because of no defrag support on ext3 on my test host.
>
> ext4/308 [not run] defragmentation not supported for fstype "ext3"
> generic/324 19s ... [not run] defragmentation not supported for fstype "ext3"
The problem is if you are using ext4 in compatibility mode for ext3
file system, it does support the defrag ioctl, but it can't support
fallocate for non-extent-mapped files (since we can't mark the blocks
as being uninitialized). (Well, we could support fallocate in
no-hide-stale mode, but that's only something that Google and Tao Bao
is using, and that patch isn't upstream anyway, since it's been
declared unclean. :-)
> ext4/308 also uses fiemap command, I think we need another check here
>
> _require_xfs_io_command "fiemap"
ext4 is always going to support the fiemap ioctl, so I think we're
good there.
Cheers,
- Ted
next prev parent reply other threads:[~2014-12-15 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 15:47 [PATCH] ext4/308,generic/324: require fallocate support Theodore Ts'o
2014-12-15 17:32 ` Eryu Guan
2014-12-15 20:02 ` Theodore Ts'o [this message]
2014-12-16 4:00 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215200209.GK17575@thunk.org \
--to=tytso@mit.edu \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox