From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:25450 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbaLOUbi (ORCPT ); Mon, 15 Dec 2014 15:31:38 -0500 Date: Tue, 16 Dec 2014 07:31:29 +1100 From: Dave Chinner Subject: Re: [PATCH 1/2] common: return failure if _check_xxx_filesystem finds corruption Message-ID: <20141215203129.GR24183@dastard> References: <1418663367-18755-1-git-send-email-eguan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418663367-18755-1-git-send-email-eguan@redhat.com> Sender: fstests-owner@vger.kernel.org To: Eryu Guan Cc: fstests@vger.kernel.org List-ID: On Tue, Dec 16, 2014 at 01:09:26AM +0800, Eryu Guan wrote: > Tests like xfs/179 depend on the return value of _check_scratch_fs to > detect fs corruption, but _check_$FSTYP_filesystem always returns 0. which means xfs/179 is wrong, because when _check_scratch_fs fails it exits immediately with status = 1, which triggers the test harness to record a test failure. (i.e. xfs/179 != check, so exits) So this change is not actually going to allow tests to check the return value of _check_scratch_fs, and check itself doesn't care if the filesystem is corrupt or not - it just reports the state and moves on to the next test.... > Also don't exit if these functions called by 'check', like what > _check_xfs_filesystem() does. That's a separate issue, and should be in it's own patch ;) Cheers, Dave. -- Dave Chinner david@fromorbit.com