From: Christoph Hellwig <hch@infradead.org>
To: Boaz Harrosh <boaz@plexistor.com>
Cc: Anna Schumaker <Anna.Schumaker@netapp.com>,
fstests@vger.kernel.org, linux-nfs@vger.kernel.org,
hch@infradead.org
Subject: Re: [PATCH] fsx: check for filesystem support of FALLOCATE_FL_KEEP_SIZE
Date: Thu, 5 Feb 2015 06:22:35 -0800 [thread overview]
Message-ID: <20150205142235.GA24816@infradead.org> (raw)
In-Reply-To: <54D37B33.9090501@plexistor.com>
On Thu, Feb 05, 2015 at 04:16:19PM +0200, Boaz Harrosh wrote:
> On 02/03/2015 11:09 PM, Anna Schumaker wrote:
> > The NFS implementation of fallocate() does not support passing the
> > KEEP_SIZE flag by itself, causing tests to randomly fail.
> >
>
> This I do not understand please explain. If all the other FSs just ignore
> a trivial case, then why should NFS not ignore it the same as all
> other filesystems.
>
> Why NFS is allowed to be special. (And apparently break user code xfs
> being an example of one)
fsx is a test tool. We've never guaranteed that a filesystem needs to
support all or a special subset of fallocate options.
The NFSv4.2 protocol doesn't support preallocations beyond the file
size, which is something I decided would be to horrible to refit into
the NFS file abstraction when rewriting the preallocation / reservation
section of the spec.
next prev parent reply other threads:[~2015-02-05 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 21:09 [PATCH] fsx: check for filesystem support of FALLOCATE_FL_KEEP_SIZE Anna Schumaker
2015-02-05 14:06 ` Christoph Hellwig
2015-02-05 14:16 ` Boaz Harrosh
2015-02-05 14:21 ` Anna Schumaker
2015-02-05 14:22 ` Christoph Hellwig [this message]
2015-02-05 14:31 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205142235.GA24816@infradead.org \
--to=hch@infradead.org \
--cc=Anna.Schumaker@netapp.com \
--cc=boaz@plexistor.com \
--cc=fstests@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox