From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Josef Bacik <jbacik@fb.com>, fstests@vger.kernel.org
Subject: Re: [PATCH V2] fstests: add a test for fallocate+truncate
Date: Tue, 26 May 2015 08:34:36 +1000 [thread overview]
Message-ID: <20150525223436.GW4316@dastard> (raw)
In-Reply-To: <20150521062910.GC1140@dhcp-13-216.nay.redhat.com>
On Thu, May 21, 2015 at 02:29:10PM +0800, Eryu Guan wrote:
> On Wed, May 20, 2015 at 10:09:59AM -0400, Josef Bacik wrote:
> > There was some confused about what the fs was supposed to do when you truncate
> > at i_size with preallocated space past i_size. We decided on the following
> > things
> >
> > 1) truncate(i_size) will trim all blocks past i_size.
> > 2) truncate(x) where x > i_size will not trim all blocks past i_size.
> >
> > This test is to make sure we're all acting sanely. Thanks,
> >
> > Signed-off-by: Josef Bacik <jbacik@fb.com>
> > ---
> > V1->V2:
> > -changed the test number
> > -fixed up minor comments from Eryu.
.....
> > index 927a91a..a801af4 100644
> > --- a/tests/generic/group
> > +++ b/tests/generic/group
> > @@ -90,6 +90,7 @@
> > 085 auto freeze mount
> > 086 auto prealloc preallocrw quick
> > 088 perms auto quick
> > +087 auto quick prealloc
>
> out-of-order seq here. Otherwise looks good to me.
I'll fix that on merge.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2015-05-25 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 14:09 [PATCH V2] fstests: add a test for fallocate+truncate Josef Bacik
2015-05-21 6:29 ` Eryu Guan
2015-05-25 22:34 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525223436.GW4316@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jbacik@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox