Re: [PATCH] generic/311: Disable dmesg check

Dave Chinner
2015-07-22T21:10:53Z

On Wed, Jul 22, 2015 at 07:28:55AM -0400, Josef Bacik wrote:
> On 07/22/2015 01:27 AM, Dave Chinner wrote:
> >>>Josef, Chris, is this really how btrfs handles metadata write
> >>>failures? This handling of errors seems like a design flaw rather
> >>>than a desireable behaviour to me....
> >>>
> >>
> >>Jeeze you are cranky Dave, lets think about what this test is doing.
> >
> >Do you really see anything above that indicates I'm cranky? I'm just
> >following the logic as i read it, reaching a conclusion and the
> >saying "this doesn't sound right - can an expert please confirm I've
> >got this right?". Last thing I expected was to be shouted at and
> >treated like an idiot.
> >
> >BTW, you'll know when I'm cranky - swearing is a real good
> >indication that I'm pissed off at something or someone.
>
> Sorry, I didn't mean to come across angry or condescending.
> Obviously I appreciate your expertise and questions, I wasn't pissed
> or anything, this is just how I normally talk, you know I use
> swearing as punctuation.

Yes, I know that, and that doesn't worry me in the least.

You don't normally shout, though.

> >>This is part of the reason for dm-log-writes, to solve this kind of
> >>shitty situation that dm-flakey introduces.
> >
> >Which you've also never explained in any of the dm-log-write patches
> >you've posted in the past. IOWs, get the dm-log-writes support code
> >reviewed and fix the dm-flakey tests to use it so this problem goes
> >away.
>
> The dm-log-writes target is already upstream, I sent the xfstests
> stuff months ago, not sure if they ever made it in. I'll check and
> get them posted again if not. Thanks,

They didn't, because it wasn't clear when the kernel code was going
to be committed. I did notice yesterday that it was upstream.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com