From: Dave Chinner <david@fromorbit.com>
To: Ari Sundholm <ari@tuxera.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] Add checks for hard links support.
Date: Mon, 31 Aug 2015 10:21:42 +1000 [thread overview]
Message-ID: <20150831002142.GN3902@dastard> (raw)
In-Reply-To: <20150830234333.GM3902@dastard>
On Mon, Aug 31, 2015 at 09:43:33AM +1000, Dave Chinner wrote:
> On Fri, Aug 28, 2015 at 01:25:00PM +0300, Ari Sundholm wrote:
> > From: Ari Sundholm <ari@tuxera.com>
> >
> > There are filesystems that do not support hard links that we want to run
> > xfstests on. Add a function for checking for support and use it wherever
> > hard links are used.
>
> As I've already pointed out, all of the filesystems that xfstests
> supports have working hardlinks, so this is a test that will never
> fail for anyone running xfstests on supported filesystems.
>
> Also, I'm left to wonder what kernel filesystem supports
> journaling but does not support hardlinks (as noted by the number of
> tests you change that have "_require_metadata_journaling"). Why
> aren't you also posting the patches to support the filesystem that
> requires this "don't use hardlinks" patch?
Just to clarify this: I don't care if people are using xfstests to
test proprietary filesystem modules. I'm happy to add proper support
for just about any filesystem, but that support needs to be *in
full* so *anyone* can run the tests on that filesystem.
What I really don't like is people being evasive about the reason
they want something changed. If there isn't a clear, full and
convincing explanation of why a change should be made, then I will
push back until such an explanation is given.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2015-08-31 0:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 10:25 [PATCH 1/2 v2] Add checks for hard links support Ari Sundholm
2015-08-30 23:43 ` Dave Chinner
2015-08-31 0:21 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831002142.GN3902@dastard \
--to=david@fromorbit.com \
--cc=ari@tuxera.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox