Re: [PATCH] generic/027: enlarge fs size for btrfs in bigger page-size machine

Filipe David Manana
2015-09-11T12:06:30Z

On Fri, Sep 11, 2015 at 12:41 PM, <xuw2015@gmail.com> wrote:
> From: George Wang <xuw2015@gmail.com>
>
> btrfs on bigger page-size machine(such as ppc64/ppc64le), the min fs
> size shoule be more than 480MB. Otherwise, the mount will fail.

Interesting, wasn't aware of that.
How does it fail? What error message do you get?

How did you calculate those values (480Mb and 512Mb)?

thanks

> So we shoud adjust the fs size to 512MB for btrfs to run this test
> correctly. And we also provide a double check: if mount fails, we should
> never run this test.
>
> Signed-off-by: George Wang <xuw2015@gmail.com>
> ---
> tests/generic/027 | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/tests/generic/027 b/tests/generic/027
> index d2e59d6..c42b9a6 100755
> --- a/tests/generic/027
> +++ b/tests/generic/027
> @@ -65,8 +65,17 @@ _require_scratch
> rm -f $seqres.full
> echo "Silence is golden"
>
> -_scratch_mkfs_sized $((256 * 1024 * 1024)) >>$seqres.full 2>&1
> -_scratch_mount
> +loop=100
> +fs_size=$((256 * 1024 * 1024))
> +# btrfs takes much longer time, reduce the loop count
> +# btrfs takes much more space when first mount on bigger page-size machine
> +if [ "$FSTYP" == "btrfs" ]; then
> + loop=10
> + fs_size=$((512 * 1024 * 1024))
> +fi
> +
> +_scratch_mkfs_sized $(fs_size) >>$seqres.full 2>&1
> +_scratch_mount || _notrun "scratch dev is not mounted successfully"
>
> echo "Reserve 2M space" >>$seqres.full
> $XFS_IO_PROG -f -c "pwrite 0 2m" $SCRATCH_MNT/testfile >>$seqres.full 2>&1
> @@ -75,12 +84,6 @@ $XFS_IO_PROG -f -c "pwrite 0 254m" $SCRATCH_MNT/bigfile >>$seqres.full 2>&1
> echo "Remove reserved file" >>$seqres.full
> rm -f $SCRATCH_MNT/testfile
>
> -loop=100
> -# btrfs takes much longer time, reduce the loop count
> -if [ "$FSTYP" == "btrfs" ]; then
> - loop=10
> -fi
> -
> dir=$SCRATCH_MNT/testdir
> echo -n "iteration" >>$seqres.full
> i=1
> --
> 1.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Filipe David Manana,

"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."