Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls

Darrick J. Wong
2015-11-12T17:35:08Z

On Thu, Nov 12, 2015 at 04:51:15AM -0800, Christoph Hellwig wrote:
> On Thu, Nov 12, 2015 at 01:07:56AM -0800, Christoph Hellwig wrote:
> > Looks fine:
> >
> > Acked-by: Christoph Hellwig <hch@lst.de>
>
> Actually I take this back. I had though this was the existing series
> with my fixes, but this one still incorrectly assumes that if reflink
> works dedup works as well, leading to lots of false failures on nfs.

Bleargh, _require_*_dedupe forgot to check for ENOTTY output, so all the dedupe
tests should have _notrun.

Also, generic/806 was calling the wrong _require.

I'll start renumbering tests; Christoph, did you see anything else?

--D

> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html