Re: [PATCH] btrfs/104: replace ugly sleep with subvol sync

[Mark Fasheh <mfasheh@suse.de>]

Hi David,

On Thu, Nov 12, 2015 at 11:49:17AM +1100, Dave Chinner wrote:
> > +# Subvol delete is a delayed operation, wait for it to complete before
> > +# unmounting.
> > +_run_btrfs_util_prog subvolume sync $SCRATCH_MNT
> 
> Won't that now fail on systems without the "subvolume sync"
> command because of the hidden use of _run_check in
> _run_btrfs_util_prog? i.e. doesn't it need to do something like:
> 
> $BTRFS_UTIL_PROG subvolume sync $SCRATCH_MNT
> if [ $? -ne 0 ]; then
> 	sleep 45
> fi
> 
> So that it works on all versions of the btrfs utility?

You know, you are probably right and I should have known because we already
talked about _run_check hiding errors! I'll fix that up and send out a new
patch once I've tested the change.

Thanks,
	--Mark

--
Mark Fasheh