From: Eryu Guan <eguan@redhat.com>
To: fdmanana@kernel.org
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH] fstests: fix btrfs/091 failure due to not found _require_cp_reflink
Date: Thu, 19 Nov 2015 11:21:45 +0800 [thread overview]
Message-ID: <20151119032145.GL2535@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1447862876-18701-1-git-send-email-fdmanana@kernel.org>
On Wed, Nov 18, 2015 at 04:07:56PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> Commit 20d7bfad2d38 ("reflink: add test support routines to a separate
> file") moved the function _require_cp_reflink to the new file
> common/reflink but forgot to make btrfs/091 source that file, leading
> to the following failure:
>
> $ ./check btrfs/091
> FSTYP -- btrfs
> PLATFORM -- Linux/x86_64 debian3 4.3.0-rc5-btrfs-next-17+
> MKFS_OPTIONS -- /dev/sdc
> MOUNT_OPTIONS -- /dev/sdc /home/fdmanana/btrfs-tests/scratch_1
>
> btrfs/091 1s ... - output mismatch (see .../results//btrfs/091.out.bad)
> --- tests/btrfs/091.out 2015-05-03 01:19:42.128976975 +0100
> +++ .../results/btrfs/091.out.bad 2015-11-18 15:56:35.332745132 +0000
> @@ -1,4 +1,5 @@
> QA output created by 091
> +./tests/btrfs/091: line 49: _require_cp_reflink: command not found
> wrote 262144/262144 bytes at offset 0
> XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> 65536 65536
> ...
> (Run 'diff -u tests/btrfs/091.out .../results/btrfs/091.out.bad' \
> to see the entire diff)
>
> So just make btrfs/091 source common/reflink in order to know the
> definition of _require_cp_reflink.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
prev parent reply other threads:[~2015-11-19 3:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 16:07 [PATCH] fstests: fix btrfs/091 failure due to not found _require_cp_reflink fdmanana
2015-11-19 3:21 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151119032145.GL2535@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox