public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [patch] fstests: remove generic/042 from the 'auto' group
Date: Wed, 2 Dec 2015 13:43:24 -0500	[thread overview]
Message-ID: <20151202184322.GA53117@bfoster.bfoster> (raw)
In-Reply-To: <x49wpswogc9.fsf@segfault.boston.devel.redhat.com>

On Wed, Dec 02, 2015 at 01:28:22PM -0500, Jeff Moyer wrote:
> Hi,
> 
> This test fails 100% of the time for me on xfs and current git head, and
> is not run for ext4 since ext4 does not support shutdown.  After talking
> with bfoster, it isn't expected to succeed right now.  Since the auto
> group is for tests that *are* expected to succeed, let's move this one
> out.
> 
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
> 

My recollection for this test was that Dave had described the delalloc
extent -> real extent stale data exposure issue and I had a thought on
how to reproduce it based on some work I was doing on the zero range
bits around that time. That happened to prove effective, so I wanted to
get the test included before I lost track of it (even though a real fix
wasn't yet available).

I had played with fixing this a bit before. IIRC, it's potentially
affected by some of the work to kill buffer_head usage in the writepages
path, so I might revisit it once that stuff is more fleshed out. Until
then, this seems reasonable to me:

Reviewed-by: Brian Foster <bfoster@redhat.com>

> diff --git a/tests/generic/group b/tests/generic/group
> index a33536e..4b70008 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -44,7 +44,7 @@
>  039 metadata auto quick
>  040 metadata auto quick
>  041 metadata auto quick
> -042 auto quick rw
> +042 quick rw
>  043 metadata log auto
>  044 metadata log auto
>  045 metadata log auto
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2015-12-02 18:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 18:28 [patch] fstests: remove generic/042 from the 'auto' group Jeff Moyer
2015-12-02 18:43 ` Brian Foster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151202184322.GA53117@bfoster.bfoster \
    --to=bfoster@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=jmoyer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox