From: Dave Chinner <david@fromorbit.com>
To: Zhaolei <zhaolei@cn.fujitsu.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] fstests: Fix generic/102 fail for btrfs
Date: Tue, 8 Dec 2015 09:12:07 +1100 [thread overview]
Message-ID: <20151207221207.GF26718@dastard> (raw)
In-Reply-To: <56d7fca5e2f5dadceb4a3ec3d4589fec54da8d3b.1449137276.git.zhaolei@cn.fujitsu.com>
On Thu, Dec 03, 2015 at 06:08:36PM +0800, Zhaolei wrote:
> From: Zhao Lei <zhaolei@cn.fujitsu.com>
>
> generic/102 sometimes fails in newest btrfs toolchain,
> because it use non-mixed mode in default, which request more space
> for metadata, and no space for data writing.
>
> This patch force mixed mode for btrfs in generic/102.
>
> Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
> ---
> tests/generic/102 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/generic/102 b/tests/generic/102
> index abc3994..8c01fb5 100755
> --- a/tests/generic/102
> +++ b/tests/generic/102
> @@ -48,6 +48,8 @@ _require_scratch
>
> rm -f $seqres.full
>
> +[[ "$FSTYP" = "btrfs" ]] && MKFS_OPTIONS+=" --mixed"
> +
> dev_size=$((512 * 1024 * 1024)) # 512MB filesystem
> _scratch_mkfs_sized $dev_size >>$seqres.full 2>&1
This sort of filesystem size specific mkfs requirement belongs in
the filesystem specific section of _scratch_mkfs_sized().
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-12-07 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 10:08 [PATCH] fstests: Fix generic/102 fail for btrfs Zhaolei
2015-12-07 22:12 ` Dave Chinner [this message]
2015-12-08 7:26 ` Zhao Lei
2015-12-09 20:32 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207221207.GF26718@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox