From: Eryu Guan <eguan@redhat.com>
To: Xiong Zhou <xzhou@redhat.com>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
dmonakhov@openvz.org
Subject: Re: [PATCH] shared: test mount needs_recovery extN partition with noload option
Date: Thu, 24 Dec 2015 16:10:10 +0800 [thread overview]
Message-ID: <20151224081010.GI2535@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1450942226-19882-1-git-send-email-xzhou@redhat.com>
On Thu, Dec 24, 2015 at 03:30:26PM +0800, Xiong Zhou wrote:
> Once upon a time, ext4 encounter NULL pointer dereference under this
> situaiton due to jump to a wrong label. Part of this commit fixed
> this Oops:
>
> 744692d ext4: use ext4_get_block_write in buffer write
>
> We can also run this test on ext2/3. Note that fsck will fail on
> ext2 due to:
> "Superblock needs_recovery flag is set, but no journal is present"
I don't think fsck is needed in this test, superblock is modified on
purpose and ext2 always fails the check. So changing _require_scratch to
_require_scratch_nocheck would be good.
Otherwise looks good to me.
Thanks,
Eryu
next parent reply other threads:[~2015-12-24 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1450942226-19882-1-git-send-email-xzhou@redhat.com>
2015-12-24 8:10 ` Eryu Guan [this message]
2015-12-25 2:20 ` [PATCH v2] shared: test mount needs_recovery extN partition with noload option Xiong Zhou
2015-12-25 4:30 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151224081010.GI2535@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=dmonakhov@openvz.org \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox