public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH 2/2] overlay: test copy up files from lower dir
Date: Tue, 12 Jan 2016 07:31:35 +1100	[thread overview]
Message-ID: <20160111203135.GA6033@dastard> (raw)
In-Reply-To: <1452512301-22145-2-git-send-email-eguan@redhat.com>

On Mon, Jan 11, 2016 at 07:38:21PM +0800, Eryu Guan wrote:
> Test copy up files from lower dir that are <, =, > 4G in size.
> 
> Kernel commit 0480334fa604 ("ovl: use O_LARGEFILE in ovl_copy_up()")
> fixed bug when copying up large file(>4G) from lower dir.
> 
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
>  tests/overlay/001      | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/overlay/001.out  |  2 ++
>  tests/overlay/Makefile | 20 +++++++++++++
>  tests/overlay/group    |  6 ++++
>  4 files changed, 104 insertions(+)
>  create mode 100755 tests/overlay/001
>  create mode 100644 tests/overlay/001.out
>  create mode 100644 tests/overlay/Makefile
>  create mode 100644 tests/overlay/group
> 
> diff --git a/tests/overlay/001 b/tests/overlay/001
> new file mode 100755
> index 0000000..5025a69
> --- /dev/null
> +++ b/tests/overlay/001
> @@ -0,0 +1,76 @@
> +#! /bin/bash
> +# FS QA Test 002

002 != 001 ;)

> +_scratch_mkfs
> +
> +# Create test files with different sizes in lower dir
> +# $SCRATCH_DEV is actually a test dir used in overlay testing
> +mkdir -p $SCRATCH_DEV/lower

This needs to matchup with the overlay configuration. Perhaps there
needs to be exported variables for this....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2016-01-11 20:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11 11:38 [PATCH 1/2] common: remove all files in $SCRATCH_DEV for overlayfs in _scratch_cleanup_files() Eryu Guan
2016-01-11 11:38 ` [PATCH 2/2] overlay: test copy up files from lower dir Eryu Guan
2016-01-11 20:31   ` Dave Chinner [this message]
2016-01-12  3:46     ` Eryu Guan
2016-01-12  4:06       ` Dave Chinner
2016-01-12  9:34         ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160111203135.GA6033@dastard \
    --to=david@fromorbit.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox