From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com ([209.132.183.28]:50281 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752650AbcALDqi (ORCPT ); Mon, 11 Jan 2016 22:46:38 -0500 Date: Tue, 12 Jan 2016 11:46:33 +0800 From: Eryu Guan Subject: Re: [PATCH 2/2] overlay: test copy up files from lower dir Message-ID: <20160112034633.GO21019@eguan.usersys.redhat.com> References: <1452512301-22145-1-git-send-email-eguan@redhat.com> <1452512301-22145-2-git-send-email-eguan@redhat.com> <20160111203135.GA6033@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160111203135.GA6033@dastard> Sender: fstests-owner@vger.kernel.org To: Dave Chinner Cc: fstests@vger.kernel.org, linux-unionfs@vger.kernel.org List-ID: On Tue, Jan 12, 2016 at 07:31:35AM +1100, Dave Chinner wrote: > On Mon, Jan 11, 2016 at 07:38:21PM +0800, Eryu Guan wrote: > > Test copy up files from lower dir that are <, =, > 4G in size. > > > > Kernel commit 0480334fa604 ("ovl: use O_LARGEFILE in ovl_copy_up()") > > fixed bug when copying up large file(>4G) from lower dir. > > > > Signed-off-by: Eryu Guan > > --- > > tests/overlay/001 | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > tests/overlay/001.out | 2 ++ > > tests/overlay/Makefile | 20 +++++++++++++ > > tests/overlay/group | 6 ++++ > > 4 files changed, 104 insertions(+) > > create mode 100755 tests/overlay/001 > > create mode 100644 tests/overlay/001.out > > create mode 100644 tests/overlay/Makefile > > create mode 100644 tests/overlay/group > > > > diff --git a/tests/overlay/001 b/tests/overlay/001 > > new file mode 100755 > > index 0000000..5025a69 > > --- /dev/null > > +++ b/tests/overlay/001 > > @@ -0,0 +1,76 @@ > > +#! /bin/bash > > +# FS QA Test 002 > > 002 != 001 ;) Ah, I missed that after "mv 002 001".. > > > +_scratch_mkfs > > + > > +# Create test files with different sizes in lower dir > > +# $SCRATCH_DEV is actually a test dir used in overlay testing > > +mkdir -p $SCRATCH_DEV/lower > > This needs to matchup with the overlay configuration. Perhaps there > needs to be exported variables for this.... Makes sense. I thought about it too but didn't go any further, but will now. Thanks for the review! Eryu